tomasr/nixpkgs-notifier
1
0
Fork 0
mirror of https://github.com/tomasriveral/nixpkgs-notifier.git synced 2026-08-11 18:28:38 +02:00
Code Issues Packages Projects Releases Wiki Activity

fix: read snapshot of tracked file and close it afterwards

Browse Source 
We were writing to the file as the file was opened in read mode. This
lead to PRs not being removed after first time notified.
This commit is contained in:
tomasr
2026-06-12 15:19:50 +02:00
parent 276b61aeca
commit 9af4538e1e
1 changed files with 32 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files
nixpkgs_notifier.py
+32 -7
View File
@@ -232,21 +232,46 @@ def main():
if pr:
print(" " + str(pr) + " " + getPRTitle(pr))
elif sys.argv[1] == "listen":
while True:
elif sys.argv[1] == "listen":
while True:
try:
if trackedPRFile.exists():
# Read a snapshot of the file first so we don't modify
# tracked.txt while iterating over it.
with trackedPRFile.open("r") as f:
tracked_prs = []
for line in f:
PR = int(line.strip())
if fetchStatus(PR) == "accepted":
line = line.strip()
if not line:
continue
tracked_prs.append(int(line))
for PR in tracked_prs:
try:
status = fetchStatus(PR)
if status == "accepted":
print(f"PR #{PR} accepted")
if shouldLocalNotify:
localNotify(PR)
if shouldMatrixNotify:
matrixNotify(PR)
removeTracker(PR)
sleep(configFetchTime) # avoids to send request to quickly to the website
sleep(configTime)
print(f"Removed PR #{PR} from tracking")
except Exception as e:
print(
f"Failed to process PR #{PR}: {e}"
)
# Avoid hammering the tracker website
sleep(configFetchTime)
except Exception as e:
print(f"Listener loop error: {e}")
sleep(configTime)
else:
print("Unknown argument \"" + sys.argv[1] + "\"\nAccepted arguments are:\n add\n remove or rm\n list or ls\n listen")