Merge (#25) from tomasriveral/fix-contributing

docs: fix forgot to update function name

.envrc

@@ -1 +1 @@
-use flake
+use nix

.github/workflows/release.yml

@@ -1,55 +0,0 @@
-name: Release PR
-
-on:
-  workflow_dispatch:
-    inputs:
-      version:
-        required: true
-
-permissions:
-  contents: write
-  pull-requests: write
-
-jobs:
-  release_pr:
-    runs-on: ubuntu-latest
-
-    steps:
-      - uses: actions/checkout@v4
-
-      - name: Configure git
-        run: |
-          git config user.name "github-actions[bot]"
-          git config user.email "github-actions[bot]@users.noreply.github.com"
-
-      - uses: DeterminateSystems/nix-installer-action@v12
-
-      - name: Create release branch
-        run: |
-          git checkout -B release/${{ inputs.version }}
-
-      - name: Set version in flake.nix
-        run: |
-          sed -i "s/version = \".*\";/version = \"${{ inputs.version }}\";/" flake.nix
-
-      - name: Update flake inputs
-        run: nix flake update
-
-      - name: Commit changes
-        run: |
-          git add flake.nix flake.lock
-          git commit -m "chore(release): ${{ inputs.version }}"
-
-      - name: Push branch
-        run: |
-          git push origin release/${{ inputs.version }}
-
-      - name: Create Pull Request
-        run: |
-          gh pr create \
-            --base main \
-            --head release/v${{ inputs.version }} \
-            --title "[Automatic] Release PR ${{ inputs.version }}" \
-            --body "Automated release PR.\nAfter the test's succesfull run, create manually a release with a new tag matching ${{ inputs.version }}"
-        env:
-          GH_TOKEN: ${{ secrets.GITHUB_TOKEN }}

.github/workflows/weeklyUpdate.yml

@@ -1,58 +0,0 @@
-name: Weekly Flake Update
-
-on:
-  schedule:
-    - cron: "0 3 * * 1"  # every Monday at 03:00 UTC
-  workflow_dispatch:
-
-permissions:
-  contents: write
-  pull-requests: write
-
-jobs:
-  flake_update:
-    runs-on: ubuntu-latest
-
-    steps:
-      - uses: actions/checkout@v4
-
-      - uses: DeterminateSystems/nix-installer-action@v12
-
-      - name: Set branch name (date)
-        id: vars
-        run: |
-          echo "branch=flake-update/$(date +%Y-%m-%d)" >> $GITHUB_OUTPUT
-
-      - name: Create update branch
-        run: |
-          git checkout -B ${{ steps.vars.outputs.branch }}
-
-      - name: Update flake inputs
-        run: |
-          nix flake update
-
-      - name: Commit changes
-        run: |
-          git config user.name "github-actions[bot]"
-          git config user.email "github-actions[bot]@users.noreply.github.com"
-          git add flake.lock
-          git commit -m "chore: weekly flake update" || echo "No changes to commit"
-
-      - name: Push branch
-        run: |
-          git push origin ${{ steps.vars.outputs.branch }} --force
-
-      - name: Install GitHub CLI
-        run: |
-          sudo apt-get update
-          sudo apt-get install -y gh
-
-      - name: Create Pull Request
-        run: |
-          gh pr create \
-            --base main \
-            --head ${{ steps.vars.outputs.branch }} \
-            --title "[Automated] Weekly flake update $(date +%Y-%m-%d)" \
-            --body "Automated weekly update of flake inputs for $(date +%Y-%m-%d)."
-        env:
-          GH_TOKEN: ${{ secrets.GITHUB_TOKEN }}

.gitignore

@@ -8,4 +8,3 @@ result
 massif.out.*
 *.out.*
 vgcore.*
-.direnv/

README.md

@@ -1,7 +1,5 @@
 # NoteWrapper
 
-Note: This project fullfills all my usecase for now, so my main source for features ideas dried out. So if you have good ideas, feel free to open an issue ;)
-
 [![Ask DeepWiki](https://deepwiki.com/badge.svg)](https://deepwiki.com/tomasriveral/notewrapper)
 
 ## Why?
@@ -57,26 +55,6 @@ You must also have a [supported editor (and their associated plugin if needed)](
 
 ## How to install
 
-### Nix flakes
-
-Add this to your inputs in flake.nix:
-
-```nix
-notewrapper = {
-  url = "github:tomasriveral/notewrapper";
-};
-```
-If your flake already inputs nixpkgs and/or flake-utils, you can follow it:
-```nix
-notewrapper = {
-  url = "github:tomasriveral/notewrapper;
-  inputs.nixpkgs.follow = "nixpkgs";
-  inputs.flake-utils.follow = "flake-utils";
-};
-```
-
-### Building from source
-
 1. Install all required dependencies listed above.
 2. Ensure you have a supported editor installed.
 3. Clone the repository:
@@ -109,7 +87,7 @@ make
 
 ---
 
-### Packaging
+## Packaging
 
 There is currently no official package available for NoteWrapper.
 

default.nix

@@ -0,0 +1,35 @@
+{ pkgs ? import <nixpkgs> {} }:
+
+pkgs.stdenv.mkDerivation {
+  pname = "notewrapper";
+  version = "1.0";
+
+  src = ./.;
+
+  nativeBuildInputs = [
+    pkgs.pkg-config
+  ];
+
+  buildInputs = [
+    pkgs.ncurses
+    pkgs.cjson
+    pkgs.fzf
+    pkgs.gnused
+    pkgs.ripgrep
+  ];
+
+  buildPhase = ''
+    make
+  '';
+
+  installPhase = ''
+    mkdir -p $out/bin
+    cp notewrapper $out/bin/
+  '';
+
+  meta = with pkgs.lib; {
+    description = " Journaling and notetaking TUI wrapper on top of neovim, vim and nano.";
+    license = licenses.gpl3Only;
+    platforms = platforms.linux;
+  };
+}

flake.lock

@@ -1,78 +0,0 @@
-{
-  "nodes": {
-    "flake-utils": {
-      "inputs": {
-        "systems": "systems"
-      },
-      "locked": {
-        "lastModified": 1731533236,
-        "narHash": "sha256-l0KFg5HjrsfsO/JpG+r7fRrqm12kzFHyUHqHCVpMMbI=",
-        "owner": "numtide",
-        "repo": "flake-utils",
-        "rev": "11707dc2f618dd54ca8739b309ec4fc024de578b",
-        "type": "github"
-      },
-      "original": {
-        "owner": "numtide",
-        "repo": "flake-utils",
-        "type": "github"
-      }
-    },
-    "nixpkgs": {
-      "locked": {
-        "lastModified": 1779508470,
-        "narHash": "sha256-Ap9KJX+5xHIn3bPIpfNgT6MEXdAECECwo4/rmlQD74M=",
-        "owner": "NixOS",
-        "repo": "nixpkgs",
-        "rev": "29916453413845e54a65b8a1cf996842300cd299",
-        "type": "github"
-      },
-      "original": {
-        "owner": "NixOS",
-        "ref": "nixos-unstable",
-        "repo": "nixpkgs",
-        "type": "github"
-      }
-    },
-    "notewrapper": {
-      "flake": false,
-      "locked": {
-        "lastModified": 1779721342,
-        "narHash": "sha256-QbRzgD4HoUUemaVCIZ2VfiW+SUjzFY2rL51CLOxQLvk=",
-        "owner": "tomasriveral",
-        "repo": "NoteWrapper",
-        "rev": "e370f98c5ebc3c037dec4e7e35f26230724b70d3",
-        "type": "github"
-      },
-      "original": {
-        "owner": "tomasriveral",
-        "repo": "NoteWrapper",
-        "type": "github"
-      }
-    },
-    "root": {
-      "inputs": {
-        "flake-utils": "flake-utils",
-        "nixpkgs": "nixpkgs",
-        "notewrapper": "notewrapper"
-      }
-    },
-    "systems": {
-      "locked": {
-        "lastModified": 1681028828,
-        "narHash": "sha256-Vy1rq5AaRuLzOxct8nz4T6wlgyUR7zLU309k9mBC768=",
-        "owner": "nix-systems",
-        "repo": "default",
-        "rev": "da67096a3b9bf56a91d16901293e51ba5b49a27e",
-        "type": "github"
-      },
-      "original": {
-        "owner": "nix-systems",
-        "repo": "default",
-        "type": "github"
-      }
-    }
-  },
-  "root": "root",
-  "version": 7
-}

flake.nix

@@ -1,66 +0,0 @@
-{
-  description = "NoteWrapper";
-
-  inputs = {
-    nixpkgs.url = "github:NixOS/nixpkgs/nixos-unstable";
-    flake-utils.url = "github:numtide/flake-utils";
-    notewrapper = {
-      url = "github:tomasriveral/NoteWrapper";
-      flake = false;
-    };
-  };
-
-  outputs = { self, nixpkgs, flake-utils, notewrapper }:
-    flake-utils.lib.eachDefaultSystem (system:
-      let
-        pkgs = import nixpkgs { inherit system; };
-      in {
-        packages.default = pkgs.stdenv.mkDerivation (finalAttrs: {
-          pname = "notewrapper";
-          version = "v2.1";
-
-          src = notewrapper;
-
-          nativeBuildInputs = with pkgs; [
-            pkg-config
-            gnumake
-          ];
-
-          buildInputs = with pkgs; [
-            ncurses
-            cjson
-            vivify
-            rsync
-            ripgrep
-            fzf
-            gnused
-          ];
-
-          buildPhase = ''
-            make VERSION=${finalAttrs.version}
-          '';
-
-          installPhase = ''
-            mkdir -p $out/bin
-            cp notewrapper $out/bin/
-          '';
-        });
-
-        devShells.default = pkgs.mkShell {
-          packages = with pkgs; [
-            cjson
-            ncurses
-            pkg-config
-            gdb
-            valgrind
-            clang-tools
-            gnumake
-          ];
-        };
-
-        apps.default = {
-          type = "app";
-          program = "${self.packages.${system}.default}/bin/notewrapper";
-        };
-      });
-}

shell.nix

@@ -0,0 +1,13 @@
+{ pkgs ? import <nixpkgs> {} }:
+
+pkgs.mkShell {
+  buildInputs = [
+    pkgs.cjson
+    pkgs.ncurses
+    pkgs.pkg-config
+    pkgs.gdb
+    pkgs.valgrind
+    pkgs.kdePackages.kcachegrind
+    pkgs.clang-tools
+  ];
+}

src/main.c

@@ -529,14 +529,9 @@ backup_config_end:
                   shouldDebug); // check if editor is supported and if it is installed. If not, it
                                 // will throw an error.
 
-    int *backupMessage = malloc(sizeof(int)); // Used later to set the backuping message.
-    *backupMessage = 0;                       // default don't show the message
-    int forceBackup = 0;
     if (doesBackup) {
-        debug("Handling normal backup");
+        debug("Handling backup");
-        forceBackup = 0;
+        handleBackups(directoriesArray, numDirectories, backupDirectoriesArray, homedir, interval, (const char **)rsyncArgs, rsyncArgsNumber, shouldDebug);
-        handleBackups(directoriesArray, numDirectories, backupDirectoriesArray, homedir, interval, (const char **)rsyncArgs, rsyncArgsNumber, forceBackup, backupMessage, shouldDebug);
-        debug("backupMessage was set to %d by a normal backup", *backupMessage);
     }
 
     initscr(); // initialize ncurses
@@ -577,26 +572,13 @@ backup_config_end:
             }
             altDebug("└ ------------------------------\n");
         }
-        int extraOptions = 3;
-        if (doesBackup) {
-            extraOptions++; // space for "Backup now" button
-        }
-        if (*backupMessage) {
-            extraOptions++;
-        }
-        vaultsArray = realloc(vaultsArray, (vaultsCount + extraOptions) * sizeof(char *)); // resize vaultsArray to fit the extra options
-        int index = 0;
-        vaultsArray[vaultsCount + index++] = "Create a new vault"; // some more options that are not vaults
-        vaultsArray[vaultsCount + index++] = "Settings";
-        if (doesBackup) {
-            vaultsArray[vaultsCount + index++] = "Backup now";
-        }
-        vaultsArray[vaultsCount + index++] = "Quit (Ctrl+C)";
-        if (*backupMessage) {
-            vaultsArray[vaultsCount + index++] = "A backup was launched. Do not immediatly close the program. After a few seconds, you can safely ignore this message.";
-        };
 
-        *backupMessage = 0; // we reset it to show the message only once
+        // adds "create a new vault" into the vaultsArray
+        const int extraOptions = 3;
+        vaultsArray = realloc(vaultsArray, (vaultsCount + extraOptions) * sizeof(char *)); // resize vaultsArray to fit the extra options
+        vaultsArray[vaultsCount] = "Create a new vault";                                   // some more options that are not vaults
+        vaultsArray[vaultsCount + 1] = "Settings";
+        vaultsArray[vaultsCount + 2] = "Quit (Ctrl+C)";
 
         vaultSelected = ncursesSelect(vaultsArray, "Select vault to open (Use arrows or WASD, Enter to select):", vaultsCount, extraOptions, " ", "Or select an option below", "", shouldDebug);
 
@@ -612,8 +594,7 @@ backup_config_end:
         }
 
         debug("Selected vault: %s", vaultSelected);
-        if (strcmp(vaultSelected, "Create a new vault") != 0 && strcmp(vaultSelected, "Settings") != 0 && strcmp(vaultSelected, "Quit (Ctrl+C)") != 0 && strcmp(vaultSelected, "Backup now") != 0 &&
+        if (strcmp(vaultSelected, "Create a new vault") != 0 && strcmp(vaultSelected, "Settings") != 0 && strcmp(vaultSelected, "Quit (Ctrl+C)") != 0) {
-            strcmp(vaultSelected, "A backup was launched. Do not immediatly close the program. After a few seconds, you can safely ignore this message.") != 0) {
         note_selection:
             bypassSelectionVault = 0; // we must reset bypassSelectionVault to not get stuck in a
                                       // infinite loop of bypassing
@@ -750,11 +731,6 @@ backup_config_end:
         } else if (strcmp(vaultSelected, "Settings") == 0) {
             openEditor(configPath, editorToOpen, 0, 0,
                        shouldDebug); // as this is not a md file we set render and jumptoEnfOfFile to 0
-        } else if (strcmp(vaultSelected, "Backup now") == 0) {
-            debug("Running a forced backup");
-            forceBackup = 1;
-            handleBackups(directoriesArray, numDirectories, backupDirectoriesArray, homedir, interval, (const char **)rsyncArgs, rsyncArgsNumber, forceBackup, backupMessage, shouldDebug);
-            debug("backupMessage was set to %d by a normal backup", *backupMessage);
         } else if (strcmp(vaultSelected, "Quit (Ctrl+C)") == 0) {
             debug("The program was exited");
             shouldExit = 1;

src/ui.c

@@ -130,16 +130,16 @@ char *createNewNote(char dirToVault[PATH_MAX], char *vaultFromDir, int bypass, c
             free(fileFullPath);
         } else { // if it is a unified journal
             char *fileFullPath = malloc(PATH_MAX);
-            snprintf(fileFullPath, PATH_MAX, "%s/%s/%s", dirToVault, vaultFromDir, fileName);
+            // we append .md directly to fileName and not only to fileFullPath to avoid passing the wrong fileName later.
-            int len = strlen(fileFullPath);
+            int lenName = strlen(fileName);
-            if (fileFullPath[len - 3] != '.' || fileFullPath[len - 2] != 'm' || fileFullPath[len - 1] != 'd') { // there might be a cleaner way to do this
+            if (fileName[lenName - 3] != '.' && fileName[lenName - 2] != 'm' && fileName[lenName - 2] != '1') {
-                error(len > PATH_MAX - 3, "user", "%s is too big (greater than PATH_MAX-3) and we can't append .md", fileFullPath);
+                strcat(fileName, ".md");
-                strncat(fileFullPath, ".md", PATH_MAX);
+                debug("We just appended .md to %s", fileName);
-                // we checked before if fileName didn't already exist.
-                // we must redo it as we add a .mode
-                struct stat st;
-                error(stat(fileFullPath, &st) == 0, "user", "%s already exists", fileFullPath);
             }
+            snprintf(fileFullPath, PATH_MAX, "%s/%s/%s", dirToVault, vaultFromDir, fileName);
+            // we verify if the file doesn't already exist as we might just have changed the fileName and (by extension) the file path.
+            struct stat metadata;
+            error(stat(fileFullPath, &metadata) == 0, "user", "%s already exists", fileFullPath);
             FILE *filePointer;
             filePointer = fopen(fileFullPath, "w"); // creates and opens the file
             error(filePointer == NULL, "program", "The %s couldn't be created.", fileFullPath);

src/utils.c

@@ -167,9 +167,8 @@ void initAppFilesAndDirs(const char *home, const int shouldDebug) {
 }
 
 void handleBackups(char **sourceDirectoryArray, const int sourceNumber, char **destinationDirectoryArray, const char *homeDir, const int interval, const char **rsyncArguments, const int rsyncArgumentsNumber,
-                   const int forceBackup, int *backupMessage, const int shouldDebug) {
+                   const int shouldDebug) {
     int shouldBackup = 0;
-
     time_t now = time(NULL);
     debug("Time since epoch is %ld", (long)now);
     char cacheFilePATH[PATH_MAX];
@@ -204,12 +203,8 @@ void handleBackups(char **sourceDirectoryArray, const int sourceNumber, char **d
             error(1, "program", "Invalid timestamp in cache file: %s", line);
         }
         double deltaTime = difftime(now, lastBackupTime);
-        if (deltaTime > interval || forceBackup) {
+        if (deltaTime > interval) {
-            if (!forceBackup) {
             debug("(difftime) %f is greater than (interval) %d -> backuping...", deltaTime, interval);
-            } else {
-                debug("Backup was forced. backuping...");
-            }
             shouldBackup = 1;
             cacheFile = fopen(cacheFilePATH, "w");
             if (!cacheFile) {
@@ -223,7 +218,6 @@ void handleBackups(char **sourceDirectoryArray, const int sourceNumber, char **d
     }
 
     if (shouldBackup) {
-        *backupMessage = 1;
         debug("A backup is needed");
         for (int i = 0; i < sourceNumber; i++) {
             debug("%s", destinationDirectoryArray[i]);

src/utils.h

@@ -81,8 +81,7 @@ If need launches in the background rsync to do the backuping.
 Each pair of source/destination will launch one rsync process.
 If a pair don't need to be backed up, the destination should be set to NULL.
 rsyncArgs is the array of arguments to be passed to rsync. Do not inclue destination or source. It
-will be added in the function.
+will be added in the function.*/
-backupMessage will be set to 1 if a backup was launched.*/
 void handleBackups(char **sourceDirectoryArray, const int sourceDirectoryNumber, char **destinationDirectoryArray, const char *homeDir, const int interval, const char **rsyncArgs, const int rsyncArgsNumber,
-                   const int forceBackup, int *backupMessage, const int shouldDebug);
+                   const int shouldDebug);
 #endif